Skip to content

Added Ruby example in Lambda-SQS with Batch failures #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 29, 2023

Conversation

higoyal01
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@boyney123
Copy link
Contributor

Thanks @higoyal01 , in the snippets array in the snippet-json file can you add your file please?

@higoyal01
Copy link
Contributor Author

Hi @boyney123, I have added my file in snippets array of the snippet-json file. Thanks!

@dpruessner
Copy link

@higoyal01 I see you added "Ruby" into languages field; I believe you also need to add an entry in the $.snippets[0].codeTabs for a description of the Ruby example-- something like:

        {
          "id": "Ruby",
          "title": "Usage Example with Ruby:",
          "description": "Consuming an SQS event with Lambda using Ruby with batch item handling.",
          "snippets": [
            {
              "snippetPath": "example.rb",
              "language": "ruby"
            }
          ]
        }

@higoyal01
Copy link
Contributor Author

Thank you for pointing this out @dpruessner. I have updated the file as per the above comment.

@yualexan yualexan merged commit d8ddf08 into aws-samples:main Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants